Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): wrong order of constructor arguments in provider #14078

Merged

Conversation

crisbeto
Copy link
Member

Fixes the constructor in the LIVE_ANNOUNCER_PROVIDER being called with the wrong arguments.

Fixes #14077.

Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments.

Fixes angular#14077.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 10, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 10, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 10, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 2fcf9e7 into angular:master Nov 14, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
Fixes the constructor in the `LIVE_ANNOUNCER_PROVIDER` being called with the wrong arguments.

Fixes #14077.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveAnnouncer wrong instanciated and breaking depending Components
5 participants