Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): form field state not updated if options are reset #14720

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 4, 2019

Fixes the state of the form field around a mat-select not being updated when the amount of options changes, causing the value to be updated.

Fixes #14709.

Fixes the state of the form field around a `mat-select` not being updated when the amount of options changes, causing the value to be updated.

Fixes angular#14709.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 4, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 4, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 4, 2019
@mmalerba mmalerba merged commit 391a9fd into angular:master Jan 4, 2019
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…ar#14720)

Fixes the state of the form field around a `mat-select` not being updated when the amount of options changes, causing the value to be updated.

Fixes angular#14709.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mat Select placeholder/label disappears when options programatically set to []
3 participants