Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Add plugin hook for createBrowser #4230

Open
sjelin opened this issue Apr 14, 2017 · 2 comments
Open

Add plugin hook for createBrowser #4230

sjelin opened this issue Apr 14, 2017 · 2 comments

Comments

@sjelin
Copy link
Contributor

sjelin commented Apr 14, 2017

People want to modify the capabilities of a browser before it is created. Seems like a legitimate use case to me. We should add a plugin hook at the top of Runner#createBrowser().

@NickTomlin
Copy link
Contributor

👍

Do we have a diagram or documentation on all the hooks/possible transformations? I feel like it would be awesome to review the current state and then come up with an "ideal" state of lifecycle methods we could expose.

@seanmay
Copy link
Contributor

seanmay commented Apr 15, 2017

I feel like this is the appropriate short-term solution.

It might cause future headaches, in terms of plugins monkey-patching content, especially if we ever look at separating the direct Selenium WebDriver bindings from that object (something I'm working on initial steps for, by turning it into a façade that proxies calls, rather than a subclass). But this shouldn't hurt too many people, and if they're taking this tack, it seems like either they aren't going to be using TS types, or they don't care about any leaking into their tests, anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants