-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config to enable auto-apply optional chaining on nullable symbol #1469
feat: add config to enable auto-apply optional chaining on nullable symbol #1469
Conversation
d027ee1
to
ba7ee34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also add a test for this. You'll have to make some updates:
- Update the
package.json
andserver/package.json
versions to be13.0.0-next.2
. This is the version your change to@angular/language-service
is in - Update the test application's
tsconfig.json
to have"strict": true
(this took me a while to figure out - Add a test to
ivy_spec.ts
Here's the commit where I finally got this to work: 7ed5d3f. You'll probably want to clean that up a bit more.
d6b55bf
to
ad5add9
Compare
vscode-ng-language-service/package.json Line 106 in ad5add9
|
Yea, I just didn’t expect it to not already be enabled in the test project 😅 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
wait for PR to land