feat(extension): Update untrusted workspace support from 'false' to '… #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
workspaceTrustLimited
branch
from
ab0c9a3
to
8087a3a
Compare
atscott
force-pushed
the
workspaceTrustLimited
branch
from
8087a3a
to
3a85bad
Compare
alxhub
approved these changes
Jun 10, 2022
…limited' The workspace trust guide for extension authors can be found here: microsoft/vscode#120251 Importantly the sectino for evaluating whether the extension should work in an untrusted workspace asks "Does my extension treat any contents of the workspace as code?". The answer to this is "yes" for the extension because we execute `ngcc` from the `node_modules` folder. However, this isn't always necessary and becomes less so with time. As library authors publish their libraries with Ivy instructions, we will not need to run `ngcc`. This commit updates the workspace trust to indicate that it's 'limited' support due to `ngcc`. In addition the command to run `ngcc` is disabled on the server and removed from the command palette.
atscott
force-pushed
the
workspaceTrustLimited
branch
from
3a85bad
to
af625e7
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…limited'
The workspace trust guide for extension authors can be found here:
microsoft/vscode#120251
Importantly the sectino for evaluating whether the extension should work
in an untrusted workspace asks "Does my extension treat any contents of the workspace as code?".
The answer to this is "yes" for the extension because we execute
ngccfrom the
node_modulesfolder. However, this isn't always necessary andbecomes less so with time. As library authors publish their libraries
with Ivy instructions, we will not need to run
ngcc.This commit updates the workspace trust to indicate that it's 'limited'
support due to
ngcc. In addition the command to runngccis disabledon the server and removed from the command palette.