Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Add the DISABLED state to form controls #1037

Closed
alorenzen opened this issue Mar 7, 2018 · 5 comments
Closed

Add the DISABLED state to form controls #1037

alorenzen opened this issue Mar 7, 2018 · 5 comments
Assignees
@alorenzen
Labels
area: forms ⚡new feature
Milestone
=v5.0.0

Comments

@alorenzen
Copy link
Contributor

TS pull requrest: angular/angular#10994
TS Design Doc: https://docs.google.com/document/d/1k_iYcgTS1cDJkyXvBWQZGPlkWZhEqAVphC0xyKSAqPs/edit
@alorenzen alorenzen added this to the V5 milestone Mar 7, 2018
@alorenzen alorenzen self-assigned this Mar 7, 2018
@chalin
Copy link
Collaborator

chalin commented Mar 8, 2018

IMHO this is also related to added support for form reset (I thought that there used to be an issue open for form reset but I can't find it atm).

@alorenzen
Copy link
Contributor Author

Yes, it is. Both have been added to the 5.0 milestone, as I'm planning to work on both in the next few weeks.

@chalin
Copy link
Collaborator

chalin commented Mar 8, 2018

Nice! Is there still an issue that can use to track the progress of form reset?

@alorenzen
Copy link
Contributor Author

#216

matanlurey pushed a commit that referenced this issue Mar 28, 2018
@alorenzen @matanlurey
feature(forms): Add initial support for disabled state to Control mod…
5d700e8 
…els.

A follow-up change will add support to the form directives.

Partial work towards #1037

PiperOrigin-RevId: 190828379
matanlurey pushed a commit that referenced this issue Mar 28, 2018
@alorenzen @matanlurey
feature(forms): Add initial support for disabled state to Control mod…
11be9f1 
…els.

A follow-up change will add support to the form directives.

Partial work towards #1037

PiperOrigin-RevId: 190828379
matanlurey pushed a commit that referenced this issue Mar 29, 2018
@TedSander @matanlurey
Automated g4 rollback of changelist 190828379.
29abbbb 
*** Reason for rollback ***

This cl is causing a TAP break.

Example:
https://sponge.corp.google.com/target?id=4792e463-ee8c-4a72-bce5-798383a0e6fe&target=//contentads/xbid/ui/plan_workspace:plan_workspace_page_test_ddc_headless-chrome-linux

*** Original change description ***

feature(forms): Add initial support for disabled state to Control models.

A follow-up change will add support to the form directives.

Partial work towards #1037

***

PiperOrigin-RevId: 190869885
alorenzen pushed a commit that referenced this issue Mar 29, 2018
@TedSander @alorenzen
Automated rollback of change.
6c90194 
*** Reason for rollback ***

This cl is causing test breakages.

*** Original change description ***

feature(forms): Add initial support for disabled state to Control models.

A follow-up change will add support to the form directives.

Partial work towards #1037

***

PiperOrigin-RevId: 190869885
matanlurey pushed a commit that referenced this issue Mar 29, 2018
@TedSander @matanlurey
Automated g4 rollback of changelist 190828379.
406b576 
*** Reason for rollback ***

This cl is causing a TAP break.

Example:
https://sponge.corp.google.com/target?id=4792e463-ee8c-4a72-bce5-798383a0e6fe&target=//contentads/xbid/ui/plan_workspace:plan_workspace_page_test_ddc_headless-chrome-linux

*** Original change description ***

feature(forms): Add initial support for disabled state to Control models.

A follow-up change will add support to the form directives.

Partial work towards #1037

***

PiperOrigin-RevId: 190869885
alorenzen pushed a commit that referenced this issue Mar 29, 2018
@TedSander @alorenzen
Automated rollback of change.
d4754b5 
*** Reason for rollback ***

This cl is causing test breakages.

*** Original change description ***

feature(forms): Add initial support for disabled state to Control models.

A follow-up change will add support to the form directives.

Partial work towards #1037

***

PiperOrigin-RevId: 190869885
matanlurey pushed a commit that referenced this issue Mar 29, 2018
@TedSander @matanlurey
Automated rollback of change.
89af0c1 
*** Reason for rollback ***

This cl is causing test breakages.

*** Original change description ***

feature(forms): Add initial support for disabled state to Control models.

A follow-up change will add support to the form directives.

Partial work towards #1037

***

PiperOrigin-RevId: 190869885
matanlurey pushed a commit that referenced this issue Apr 4, 2018
@alorenzen @matanlurey
feature(forms): Add initial support for disabled state to Control mod…
4b94fb0 
…els.

A follow-up change will add support to the form directives.

Partial work towards #1037

Note, this fixes the bug found in the first attempt by handling the case that Group or Array are empty.

PiperOrigin-RevId: 191366364
matanlurey pushed a commit that referenced this issue Apr 4, 2018
@alorenzen @matanlurey
feature(forms): Add initial support for disabled state to Control mod…
bcbda95 
…els.

A follow-up change will add support to the form directives.

Partial work towards #1037

Note, this fixes the bug found in the first attempt by handling the case that Group or Array are empty.

PiperOrigin-RevId: 191366364
matanlurey pushed a commit that referenced this issue Apr 4, 2018
@alorenzen @matanlurey
feature(forms): Add initial support for disabled state to Control mod…
7473335 
…els.

A follow-up change will add support to the form directives.

Partial work towards #1037

Note, this fixes the bug found in the first attempt by handling the case that Group or Array are empty.

PiperOrigin-RevId: 191366364
matanlurey pushed a commit that referenced this issue Apr 23, 2018
@alorenzen @matanlurey
feature(forms): Support disabled state in directives.
6ece0b7 
More work towards #1037

PiperOrigin-RevId: 193984475
matanlurey pushed a commit that referenced this issue Apr 23, 2018
@alorenzen @matanlurey
feature(forms): Support disabled state in directives.
2fa81e5 
More work towards #1037

PiperOrigin-RevId: 193984475
@alorenzen
Copy link
Contributor Author

This is now supported, via a [ngDisabled] attribute. There were too many existing, conflicting usages of [disabled] to support that directly.

See 3ca1de1 for an example of how to use it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alorenzen alorenzen

Labels
area: forms ⚡new feature
Projects
None yet
Milestone
=v5.0.0
Development

No branches or pull requests
2 participants
@alorenzen @chalin