This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

GenerateInjector should fail more gracefully on non-classes #1633

Closed

matanlurey opened this issue Oct 8, 2018 · 0 comments

Labels

area: compiler ⛈ experience: dev cycle

Contributor

matanlurey commented Oct 8, 2018

The following syntax:

typedef SomeFunctionType = void Function();

@GenerateInjector([
  SomeFunctionType
])

... is syntactically, but not semantically valid.

A naked type (i.e. SomeFunctionType) is an alias for ClassProvider(SELF).

A ClassProvider is not valid on a function type.

The text was updated successfully, but these errors were encountered:

matanlurey added area: compiler ⛈ experience: dev cycle labels

alorenzen pushed a commit that referenced this issue


          fix(Compiler): Fail with better errors on an invalid implicit provider.

0f7325f

Previously, we would give a mysterious type error attempting to cast to ClassElement. We also now include the file entrypoint being parsed, and the source of the type itself in the error message.

Closes #1633.

PiperOrigin-RevId: 216255169

alorenzen pushed a commit that referenced this issue


          fix(Compiler): Fail with better errors on an invalid implicit provider.

223a4b1

Previously, we would give a mysterious type error attempting to cast to ClassElement. We also now include the file entrypoint being parsed, and the source of the type itself in the error message.

Closes #1633.

PiperOrigin-RevId: 216255169

alorenzen pushed a commit that referenced this issue


          fix(Compiler): Fail with better errors on an invalid implicit provider.

9c715fe

Previously, we would give a mysterious type error attempting to cast to ClassElement. We also now include the file entrypoint being parsed, and the source of the type itself in the error message.

Closes #1633.

PiperOrigin-RevId: 216255169

alorenzen pushed a commit that referenced this issue


          fix(Compiler): Fail with better errors on an invalid implicit provider.

99a34cb

Previously, we would give a mysterious type error attempting to cast to ClassElement. We also now include the file entrypoint being parsed, and the source of the type itself in the error message.

Closes #1633.

PiperOrigin-RevId: 216255169

alorenzen closed this as completed in

13b59dd

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.