Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Restore no-check-changes for NgIf #453

Closed
matanlurey opened this issue Jun 11, 2017 · 0 comments
Closed

Restore no-check-changes for NgIf #453

matanlurey opened this issue Jun 11, 2017 · 0 comments
Assignees
@matanlurey
Labels
area: runtime ⛈ experience: dev cycle ☄ problem: bug
Milestone
V4 Alpha

Comments

@matanlurey
Copy link
Contributor

No description provided.

@matanlurey matanlurey added this to the V4 Alpha milestone Jun 11, 2017
@matanlurey matanlurey self-assigned this Jun 11, 2017
alorenzen pushed a commit that referenced this issue Jun 29, 2017
@matanlurey @alorenzen
fix(NgIf): Restore use of checkBinding for dev-mode.
57e5c17 
This ensures that the checked value does not change during change detection, but it only occurs in dev-mode (assertions enabled, etc).

* Added a regression test to if_test.dart
* Made if_test.dart more consistent and debuggable

Fixes #453.

Roll-forward of cr/150807999.

DO NOT ROLLBACK for individual breakages. See:
g/dart-angular/rmavx2okJtY/zPY76Ep0AgAJ

PiperOrigin-RevId: 160532511
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matanlurey matanlurey

Labels
area: runtime ⛈ experience: dev cycle ☄ problem: bug
Projects
None yet
Milestone
V4 Alpha
Development

No branches or pull requests
1 participant
@matanlurey