Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: ExecuteRectClipLines (aka RectClipLines, previously) seems to be broken in 1.2.2 #530

Closed
AngusJohnson opened this issue May 22, 2023 Discussed in #529 · 2 comments
Closed

Comments

@AngusJohnson
Copy link
Owner

Discussed in #529

Originally posted by GeneralGDA May 22, 2023
In the 1.1.1 NuGet package everything is OK. I updated to the 1.2.2 NuGet and now RectLicpLines returns the rect boundaries. For example, let's take the rect with min (0, 0), and max (8, 8). And clip with it a line: (4, 4), (4, 5), (9, 5), (9, 4), (5, 4)

I expect the output contains two separate lines. But the 1.2.2 clipper returns single line. It includes the rect boundary.

@AngusJohnson
Copy link
Owner Author

This is a C# only bug, and here's the fix:
Replace this line with ...
Add(ip, true);

AngusJohnson added a commit that referenced this issue May 26, 2023
  to RectClip and RectClipLines respectively.
Fixed minor C# offsetting bugs
Fixed RectClipLines bug (C# only) (#530)
@AngusJohnson
Copy link
Owner Author

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant