-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add light house to CI and improvements #129
Conversation
Thanks for the PR man 👍 Although we need some good amount of integration and e2e tests to actually utilize those caching 😆 Mostly in each PR instances, we might delete the As we don't have those tests now, we can cache it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you drop node 8 and add node
- 9
- 10
- 13.2.0
Let's see how it works with the new node 👍
@all-contributors please add @jeffin143 for infra, bug, code |
I've put up a pull request to add @jeffin143! 🎉 |
Not sure, would that reduce time