Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light house to CI and improvements #129

Merged
merged 9 commits into from
Nov 30, 2019
Merged

Add light house to CI and improvements #129

merged 9 commits into from
Nov 30, 2019

Conversation

jeffin143
Copy link
Collaborator

Not sure, would that reduce time

.travis.yml Show resolved Hide resolved
@anikethsaha
Copy link
Owner

Thanks for the PR man 👍

Although we need some good amount of integration and e2e tests to actually utilize those caching 😆
And based on those tests we can increase or drop the caching directories.

Mostly in each PR instances, we might delete the bin and dist folders and build it again just to check if we are getting is fine or not.

As we don't have those tests now, we can cache it 👍

Copy link
Owner

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop node 8 and add node

  • 9
  • 10
  • 13.2.0

Let's see how it works with the new node 👍

@jeffin143 jeffin143 changed the title Do some more caching Add light house to CI and improvements Nov 30, 2019
@anikethsaha anikethsaha merged commit 770f424 into anikethsaha:master Nov 30, 2019
@anikethsaha
Copy link
Owner

@all-contributors please add @jeffin143 for infra, bug, code

@allcontributors
Copy link
Contributor

@anikethsaha

I've put up a pull request to add @jeffin143! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants