Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all graphs use one-indexed notation #5

Open
GaurangTandon opened this issue Mar 18, 2020 · 2 comments
Open

Make all graphs use one-indexed notation #5

GaurangTandon opened this issue Mar 18, 2020 · 2 comments
Assignees
Labels
enhancement Improving the quality of code and testing on the notebook

Comments

@GaurangTandon
Copy link
Collaborator

GaurangTandon commented Mar 18, 2020

I have been using one-indexed node numbering for so long and haven't broken a sweat.

It's just so much easier to use since even all the questions use one-indexing you don't have to worry about subtracting anything while reading input and using it.

Having to subtract 1 every time after reading input feels pointless once you get used to this.

Can we just do a quick run through of our codes for enforcing this notation? Or contrary thoughts?

@GaurangTandon GaurangTandon added the enhancement Improving the quality of code and testing on the notebook label Mar 18, 2020
@AnimeshSinha1309
Copy link
Owner

Although I love the 0 indexed notation and am strongly against using anything 1 indexed, I concede to your superior experience, and am willing to change that across our code. Though writing cin >> u >> v; u--, v--; is not too much of an effort, I agree that 0 indexed problems are a lot rarer on codeforces and in ICPC. Consider this and change.

@AnimeshSinha1309
Copy link
Owner

One thing to think of here is that our automated testing libraries have 0 index test problems, so we would also have to rewrite all the tests as well.

@AnimeshSinha1309 AnimeshSinha1309 added this to the Notebook Release milestone Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving the quality of code and testing on the notebook
Projects
None yet
Development

No branches or pull requests

2 participants