[REPLICATE_ATTRIBUTES] should check if tracked value has changed before updating

[hariprasadiit]

In the code whether the tracked attributes value has changed or not is not checked. This results in writes even if there's no change to tracked attributes.

// Check if atleast one of the attributes to be replicated was changed
      let relevantUpdate = false;
      Object.keys(newValue).forEach(changedAttribute => {
        if (trackedMasterAttributes[changedAttribute]) {
          relevantUpdate = true;
        }
      });

We should be comparing old values of tracked attributes to new values, like

// Check if atleast one of the attributes to be replicated was changed
      let relevantUpdate = false;
      Object.keys(newValue).forEach(changedAttribute => {
        if (trackedMasterAttributes[changedAttribute] && newValue[changedAttribute] !== oldValue[changedAttribute]) {
          relevantUpdate = true;
        }
      });

[anishkny]

Oh thats a great optimization @hariprasadiit! Although, did you mean:

if (
  trackedMasterAttributes[changedAttribute] &&
  (newValue[changedAttribute] !== oldValue[changedAttribute])
) {
  relevantUpdate = true;
}

i.e. its relevant only if old and new values are not equal.

[hariprasadiit]

yes, the values should not be equal. typo!!

[anishkny]

Fixed by #59