Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Update user personal details is not working if the same username is used | CROSS PROJECT ISSUE #141

Open
rpattath opened this issue Sep 18, 2020 · 8 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Bug Bug or Bug fixes.

Comments

@rpattath
Copy link
Member

rpattath commented Sep 18, 2020

Describe the bug
Edit the personal information of the logged in user is not working.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'My Space -> Profile -> Personal Details"
  2. Change any field.
  3. Save the changes
  4. See error
    INFO:werkzeug:127.0.0.1 - - [18/Sep/2020 11:07:36] "OPTIONS /user/personal_details HTTP/1.1" 200 -
    CRITICAL:root:{'message': 'A user with that username already exists.'}
    127.0.0.1 - - [18/Sep/2020 11:07:36] "PUT /user/personal_details HTTP/1.1" 400 -
    INFO:werkzeug:127.0.0.1 - - [18/Sep/2020 11:07:36] "PUT /user/personal_details HTTP/1.1" 400 -

Expected behavior
Personal detail update should be successful

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Fedora linux
  • Browser: Chrome
@rpattath rpattath added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes. labels Sep 18, 2020
@rpattath rpattath changed the title Update user personal details - uncheck mentee option and save fails Update user personal details is not working Sep 18, 2020
@mtreacy002
Copy link
Member

@rpattath , thank you for opening this 🎉. I had this at the back of my mind, just didn't get a chance to do it 😊. This is a cross-project issue as the MS requires user to also change their username if they want to update details. This issue also been raised on MS which I mentioned on the PR #74 for this endpoint.

@mtreacy002 mtreacy002 changed the title Update user personal details is not working Update user personal details is not working if the same username is used | CROSS PROJECT ISSUE Sep 20, 2020
@mtreacy002
Copy link
Member

I've changed the title a bit to make it clear why it is not working.

@mtreacy002 mtreacy002 changed the title Update user personal details is not working if the same username is used | CROSS PROJECT ISSUE Bug: Update user personal details is not working if the same username is used | CROSS PROJECT ISSUE Sep 20, 2020
@HeroicHitesh
Copy link
Member

I am not sure but I guess this is the issue because of which some of the fields in the profile always shows up as empty even after updating them in mentorship-android app🤔

@mtreacy002
Copy link
Member

@HeroicHitesh , you can try to change the username. It'll be accepted even if there are empty non-required fields in them. Which means, the issue is because of the existing logic required username to be changed on any update, which is not a common logic, so we need to change it at MS backend.

@mtreacy002
Copy link
Member

I am not sure but I guess this is the issue because of which some of the fields in the profile always shows up as empty even after updating them in mentorship-android app🤔

For fields still showing as empty even after updating on MS Android, have you tried to refresh the page? If it still didn't change after refreshing the page, then you probably should check if there's a bug report on this already made. If nonee, then you can open one.

@ashokrayal
Copy link

Hi,

I would like to work on this one.

@mtreacy002
Copy link
Member

@ashokrayal. This PR is tightly-coupled with issue 596 of MS backend. MS backend PR 855 to fix this issue is currently under review. Please keep an eye on that PR 855, since only once that PR is approved and merged to MS backend develop branch, we can make relevant modification onto BIT (BridgeInTech). So, please comeback to claim this issue once that PR is finalized. 😉

@ashokrayal
Copy link

Ok. Thanks, @mtreacy002

@mtreacy002 mtreacy002 added the Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. label Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

4 participants