Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Develop Sign Up page #248

Open
3 tasks
mtreacy002 opened this issue May 22, 2021 · 8 comments · May be fixed by #262
Open
3 tasks

UI: Develop Sign Up page #248

mtreacy002 opened this issue May 22, 2021 · 8 comments · May be fixed by #262
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Type: Enhancement New feature or request.

Comments

@mtreacy002
Copy link
Member

mtreacy002 commented May 22, 2021

Description

As a maintainer,
I need to see BIT Sign Up page gets redesigned,
so that I can make sure they meet AnitaB guidelines.

Mocks

Approved design idea for Sign Up page (Designer Gloria Osoro)
Screen Shot 2021-05-22 at 6 25 02 pm

Acceptance Criteria

Update [Required]

  • Implement the design above in the section it is intended in the design above.

Enhancement to Update [Optional]

NA

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 day

Additional Note
Image and design metrics can be found on Figma file under high_fidelity tab.

@mtreacy002 mtreacy002 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels May 22, 2021
@aakankshaagr
Copy link

@mtreacy002 Can I work on this issue?

@mtreacy002
Copy link
Member Author

sure, @aakankshaagr . I'll assign you to this now. Thanks for picking up the issue 😉

@mtreacy002 mtreacy002 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 23, 2021
@vj-codes
Copy link
Member

@aakankshaagr any updates here?

@aakankshaagr
Copy link

@vj-codes It's almost done. I am facing some issues. After solving them I will create a PR. ,probably within 2 days. I saw that there is some issues with navigation bar that's why I didn't make a PR earlier.

@mtreacy002
Copy link
Member Author

@aakankshaagr , can you please give us update on this?

@aakankshaagr
Copy link

Sorry @mtreacy002 I was sick due to vaccination and I completely forgot about linking PR. I will make a PR by tmr.
I didn't find left image in image section so earlier I took snap from figma and adjusted that, later I forgot to ask about this.
Can you please tell me what's the destination of image?

@mtreacy002
Copy link
Member Author

mtreacy002 commented Jun 25, 2021

Sorry to hear you had reactions to the vaccine. Hope you're all well now, @aakankshaagr. As for the image, it can be found on the figma file under the high_fidelity section which has all designs from Sign-In/Sign-Up and Homepage.
Screen Shot 2021-06-26 at 8 45 56 am

@aakankshaagr aakankshaagr linked a pull request Jun 27, 2021 that will close this issue
4 tasks
@aakankshaagr
Copy link

aakankshaagr commented Jun 27, 2021

Thanks @mtreacy002 I have linked PR for follow up. There are some changes yet to be done

  1. Show password icon
  2. terms and conditions,mentor,mentees availability and checkboxes layout
  3. Responsive page
    4.side-image

I have tried 3 methods to load side_image but still it's not showing up.Can you please point out where I am going wrong?
1.Using background-image in css
2. Importing image in register.jsx and
3. specifying path in img src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Type: Enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants