Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed SignUpActivity and Strings #1138

Merged
merged 1 commit into from
Jun 8, 2021
Merged

changed SignUpActivity and Strings #1138

merged 1 commit into from
Jun 8, 2021

Conversation

Ankit-akumar
Copy link
Contributor

@Ankit-akumar Ankit-akumar commented May 29, 2021

Description

A complete discussion over this can be found here.
Current Behaviour: Simply shows a toast to the user saying "Invalid XYZ".
Changed Behaviour: Gives a detailed error message for any invalid input.
Following screenshots would be helpful ->

Fixes #1137

Changed the validateDetails method of SignUpActivity.kt for setting the appropriate error message to be displayed to the user. Added the messages in strings.xml.
(And rearranged some lines of code unintentionally :-) )

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Steps to reproduce ->

  1. Start the app.
  2. Navigate to Signup activity by clicking the SignUp button.
  3. Enter the following strings as test cases or create your own.
  • name: B, username: bro, email: bro@bro.com, password: Bro@123. (use to check the required length of strings)
  • name: B$, username: Big bro, email: bro@bro.com, password: BigBro@123. (use to check the required format of strings.)
  • name: Big Bro, username: Big_bro, email: bro@bro.com, password: BigBro@123. (These are the valid inputs)

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@epicadk
Copy link
Member

epicadk commented May 29, 2021

Looks good. Thankyou. Needs @isabelcosta 's approval to run workflows.

@epicadk epicadk added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jun 1, 2021
@epicadk
Copy link
Member

epicadk commented Jun 1, 2021

@isabelcosta can you please approve request to run the workflow?

@epicadk epicadk self-assigned this Jun 8, 2021
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @Ankit-akumar ! Awesome work!

@isabelcosta
Copy link
Member

isabelcosta commented Jun 8, 2021

@Ankit-akumar I noticed in your PR description, the way you linked the issue was not a way that would make GitHub close the issue once this one got merged. So I changed from:

**Fixes** # [[ISSUE](https://github.com/anitab-org/mentorship-android/issues/1137)]

to

Fixes #1137

and this way, github will know which issue on the platform you are referring to :)

@isabelcosta isabelcosta merged commit 8373ae5 into anitab-org:develop Jun 8, 2021
@Ankit-akumar Ankit-akumar deleted the Improve-responses-to-user branch June 9, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement in responses provided to user
3 participants