changed SignUpActivity and Strings #1138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A complete discussion over this can be found here.
Current Behaviour: Simply shows a toast to the user saying "Invalid XYZ".
Changed Behaviour: Gives a detailed error message for any invalid input.
Following screenshots would be helpful ->
Fixes #1137
Changed the validateDetails method of SignUpActivity.kt for setting the appropriate error message to be displayed to the user. Added the messages in strings.xml.
(And rearranged some lines of code unintentionally :-) )
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Steps to reproduce ->
Checklist:
Code/Quality Assurance Only