Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Added a 'Cancel' button to the left of 'Submit' button in the 'Change Password' dialog box. #79

Closed
wants to merge 26 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 21, 2020

Description

Added a 'cancel' button on the left of 'submit' button in the 'change password' dialog box.

Fixes #64

Flutter Channel:

  • I have used the Flutter Beta channel on my local machine

Type of Change:

  • Code
  • User Interface

Code/Quality Assurance Only
Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

On clicking the 'cancel' button, the dialog box closes and the changes made to the password are discarded.

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas.

Code/Quality Assurance Only
My changes generate no new warnings
cancel_button

Jayesh Nirve and others added 26 commits April 16, 2020 02:18
* add reporting guidelines

* fix pull request template
* add code of conduct

* Create main.yml

* Update main.yml

* Update main.yml

add lib to workflow file to build app on changes to any dart file

* Delete code_of_conduct.md
* Create CODEOWNERS

* Update CODEOWNERS

* Update CODEOWNERS
* docs: Create Code of Conduct

* Removed a modified file from pull request

* changed code_of_conduct.md
PR template will now be preloaded when one tries to open a new PR
* docs: Create CONTRIBUTING.md file
* Changed 'stable' to 'beta'
* travis

* Update README.md

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update generate-apks.sh

* Update generate-apks.sh

* Update .travis.yml

* Travis finalized

* Update README.md

* Update generate-apks.sh

* fix android licenses permissions

it's a good practice :)
* Update links to COC, Contributing and Reporting guidelines, and README
Replaced the existing link of Code of Conduct to the new link which is code_of_conduct.md
* docs : Add User Story template to project #40

* Update user-story.md
* enhancment: About page ui done

* clean code

* contri => contributing
* feat: add splash screen

* cleaner pubspec
Added a cancel button on change passowrd dialog box.
@ghost
Copy link
Author

ghost commented May 21, 2020

@HaripriyaB , @isabelcosta , @bartekpacia .
Please review. :)

@HaripriyaB
Copy link
Contributor

@Mahekhan there is something wrong in the commits. I'm wondering how did all the previous commits of the repo came in to this PR. @techno-disaster @bartekpacia pls check this coz I'm confused looking at this!

@ghost
Copy link
Author

ghost commented May 21, 2020

@Mahekhan there is something wrong in the commits. I'm wondering how did all the previous commits of the repo came in to this PR. @techno-disaster @bartekpacia pls check this coz I'm confused looking at this!

oh, yes. I just saw.
I don't know.
Yes, @techno-disaster , @bartekpacia , please help.

@HaripriyaB
Copy link
Contributor

I think it's because you haven't pulled the repo to Ur local branch? Not sure

@techno-disaster
Copy link
Contributor

@Mahekhan looks like you are comparing the fork with master branch. change it to develop .
also you might have to use a different fork branch coz u already have a PR running on ur develop fork branch.

@techno-disaster
Copy link
Contributor

Closing PR
Reason : Issue was a First Timer only

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants