Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CORS policy change in Chrome 59? #15

Closed
wheeyls opened this issue Jun 21, 2017 · 2 comments
Closed

Address CORS policy change in Chrome 59? #15

wheeyls opened this issue Jun 21, 2017 · 2 comments

Comments

@wheeyls
Copy link
Contributor

wheeyls commented Jun 21, 2017

Chrome just changed the way they handle cross-origin sendBeacon requests.

https://bugs.chromium.org/p/chromium/issues/detail?id=490015

From what I understand, they don't want cross origin requests to be able to send JSON, but they are allowed to send plaintext. It will be up to the server to deal with the difference in format and deal with the request accordingly.

We got dinged with this in our implementation, because right now we host the JS on our www domain, and send CORS requests to our track subdomain. Our current plan is to change the way we host the file so that the CORS isn't required, but I'm curious if you think that this is worth updating the library to handle this scenario?

@ankane
Copy link
Owner

ankane commented Oct 30, 2017

Hey @wheeyls, thanks for reporting 👍 This is something we should address in Ahoy, since it shouldn't require CORS.

@ankane
Copy link
Owner

ankane commented Feb 23, 2018

Fixed on master. It'll go out sometime in the next few days with the release of Ahoy.js 1.0.

@ankane ankane closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants