Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order of precedence #3

Closed
sbeckeriv opened this issue May 9, 2014 · 3 comments
Closed

order of precedence #3

sbeckeriv opened this issue May 9, 2014 · 3 comments

Comments

@sbeckeriv
Copy link
Contributor

I am little unsure I am thinking of it incorrectly or there is an issue.

I set

AhoyEmail.track message: false, click: false 

Then in my mailer that I do want to track I call track

track user: @user 

It does not appear to track my message. If I remove the my AhoyEmail setting I get an error that I will cut a new issue for and look in to.

Should the mailer level tracking over write the AhoyEmail setting? I would think that it should. The auto tracking is nice but I really don't want to track every email.

@ankane
Copy link
Owner

ankane commented May 9, 2014

The track options are merged, so you'll need to pass track user: @user, message: true. I was worried this would be a bit confusing.

@sbeckeriv
Copy link
Contributor Author

Now that I see the code it makes sense. Would I ever call track user:@user with out tracking the message?

@ankane ankane closed this as completed in 485d867 May 10, 2014
@ankane
Copy link
Owner

ankane commented May 10, 2014

Definitely not in the majority of cases. This will be changed / fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants