Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in processor #90

Closed
Extrapolator214 opened this issue Jul 25, 2017 · 2 comments
Closed

error in processor #90

Extrapolator214 opened this issue Jul 25, 2017 · 2 comments

Comments

@Extrapolator214
Copy link

https://github.com/ankane/ahoy_email/blob/master/lib/ahoy_email/processor.rb#L106

params = uri.query_values(Array) || []

uri.query_values accepts only hash, not a class. Because of this, any email containing links with params throws an error TypeError - no implicit conversion of Class into Hash
It seems like a critical bug, unless I'm missing something.

@Extrapolator214
Copy link
Author

actually I had addressable 2.2.8, the error is fixed after updating to 2.5. Probably it's worth updating addressable dependency though :)

@ankane ankane closed this as completed in 97e36c6 Jul 26, 2017
@ankane
Copy link
Owner

ankane commented Jul 26, 2017

@Extrapolator214 thanks for reporting 👍 Master now specifies a min version (2.3.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants