Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inBatches forgets to submit last (partial) batch #8

Closed
timshac opened this issue Oct 30, 2018 · 1 comment
Closed

inBatches forgets to submit last (partial) batch #8

timshac opened this issue Oct 30, 2018 · 1 comment

Comments

@timshac
Copy link

timshac commented Oct 30, 2018

In helpers.R

batch_count <- row_count/batch_size should be
batch_count <- ceiling(row_count/batch_size)
so that 1:batch_count is a sequence that includes the last batch.

-Tim
@ankane ankane closed this as completed in dc119e7 Oct 30, 2018
@ankane
Copy link
Owner

ankane commented Oct 30, 2018

Hey @timshac, thanks for reporting and getting to the bottom of it 👍 Fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankane @timshac