Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(ci): upload logs on timeout #16255

Merged
merged 1 commit into from
Apr 25, 2024
Merged

build(ci): upload logs on timeout #16255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests_unit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ jobs:
arguments: jacocoUnitTestReport --daemon

- name: Store Logcat as Artifact
if: failure()
# cancelled() handles test timeouts
# remove when test timeouts cause a failure()
if: failure() || cancelled()
Copy link
Member

@mikehardy mikehardy Apr 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears it may be (untested) possible to do:

Suggested change
if: failure() || cancelled()
if: '!success()'

...and catch every single case except success, but failure && cancelled also seems sufficient

(https://stackoverflow.com/a/58859404/9910298)

uses: actions/upload-artifact@v3
with:
name: logcat-${{ matrix.name }}
Expand Down
Loading