Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start Reviewer port #16455

Merged
merged 5 commits into from
May 28, 2024
Merged

feat: start Reviewer port #16455

merged 5 commits into from
May 28, 2024

Conversation

BrayanDSO
Copy link
Member

Purpose / Description

I was going to finish it locally before pushing to avoid churn if I decide to refactor something, but I ended up procrastinating because of it. So, done is better than perfect.

It is currently a developer option. The design features are going to be implemented incrementally to ease the reviewing process and discussion.

When enough features are implemented, my plan is to move it into Settings > Advanced > Experimental

Right now it rate cards and exits when finished. Awesome, isn't it?

Fixes

Approach

In the commits

How Has This Been Tested?

Emulator 34:

Light theme screenshot

Screenshot_20240522_144052

reviewer.webm

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO
Copy link
Member Author

I haven't chosen the dark mode colors for the answer buttons yet, and choosing colors take time. Open to suggestions, but definitely don't want to bikeshed the PR because of colors. That always can be changed later

@criticalAY
Copy link
Contributor

UI: (Ik its in development mode but still pointing it out just in case) The answer button are bit overflowing ig ?

@BrayanDSO

This comment was marked as resolved.

@BrayanDSO
Copy link
Member Author

Current layout plan:

Screenshot from 2024-05-22 15-12-10

@criticalAY
Copy link
Contributor

I meant
image
the layout above and the buttons layout is not aligned here

@criticalAY
Copy link
Contributor

Current layout plan:

This is the updated one in the PR or you plan to have it this way, as it has perfect alignment

@BrayanDSO
Copy link
Member Author

BrayanDSO commented May 22, 2024

didn't copy that part when branching. Updated it. Thanks! (note: haven't updated the video )

currently, it does nothing. This commit is just to simplify the reviewing process
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question

@BrayanDSO BrayanDSO added squash-merge The pull request currently requires maintainers to "Squash Merge" labels May 27, 2024
@BrayanDSO BrayanDSO marked this pull request as draft May 27, 2024 09:19
@BrayanDSO BrayanDSO marked this pull request as ready for review May 27, 2024 09:22
the style and features are going to be implemented incrementally
ReviewerFragmentTest is basically a copy of ReviewerTest
@BrayanDSO BrayanDSO removed the squash-merge The pull request currently requires maintainers to "Squash Merge" label May 27, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the understanding that this is development only

No point in blocking

Only encouragement is to add more tests - now is a great opportunity to improve coverage

@@ -0,0 +1,184 @@
/*
* This program is free software; you can redistribute it and/or modify it under
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No copyright?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically a copy of ReviewerTest, which doesn't have an author in the copyright header, and I didn't want to license it all under myself

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels May 27, 2024
@snowtimeglass

This comment was marked as resolved.

@BrayanDSO

This comment was marked as resolved.

@lukstbit
Copy link
Contributor

Also LGTM. UI design issues can be discussed later.

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels May 28, 2024
@lukstbit lukstbit added this pull request to the merge queue May 28, 2024
Merged via the queue into ankidroid:main with commit c2bb60d May 28, 2024
7 of 8 checks passed
@github-actions github-actions bot added this to the 2.19 release milestone May 28, 2024
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label May 28, 2024
@BrayanDSO BrayanDSO deleted the rev-init branch June 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants