Adapt to PaperTrail v9 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This requires to increase PT minimum version to 4.
… their code its exactly the same.
|
I don't know if this repository is maintained any longer since there hasn't been a release in a very long time, but this is sorely needed for Rails 5.2 and going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on #7, PaperTrail v9 includes changes that break this gem. This PR fix that errors, trying to keep backward compatibility.
I've tested manually against different versions of PT, and all tests passes within v4, v8 and v9, but not within v3. That's why I've changed the minimum PT version to 4.0.0 in the
.gemspecfile.