Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered decks should shuffle identical values #3214

Closed
dae opened this issue May 28, 2024 · 0 comments · Fixed by #3259
Closed

Filtered decks should shuffle identical values #3214

dae opened this issue May 28, 2024 · 0 comments · Fixed by #3259

Comments

@dae
Copy link
Member

dae commented May 28, 2024

All our standard deck orders end with with equivalent of , random(), so that cards due on the same day don't always appear in the same order for example. We don't do this for filtered decks, which can cause things like reviewing ahead to show cards in a predictable order. Perhaps we should be doing something similar to the standard review process instead, updating order_and_limit_for_search() to sort by fnvhash(id, mod) like the standard review process does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant