Optimizing FSRS parameters shows 0 reviews

[user1823]

However, sometimes, it does show the correct count too.

Test file: Test.apkg.zip (Rename to remove .zip)

In this file, try to optimize the parameters of the deck B (subdeck of A) to reproduce the issue.

[abdnh]

No luck reproducing this here.

[user1823]

I imported the apkg into a fresh profile and I was able to reproduce it a few times. The issue seems to appear randomly.

However, I have reasons to think that the issue is more likely to be reproduced when the optimization finishes too fast (probably indicating a race condition).

For e.g., if I start a screen recording, the CPU usage increases and the laptop becomes slightly slower and I am almost never able to reproduce the issue.

[benasocj]

I experience the same issue.

In the following scenarios the parameters have always been optimized already. For this reason the "...appear to be optimal" popup is always shown (which is expected).

Following scenarios I have come across:

1. Only "0 reviews" shown

Popup is shown:

After I close the popup:

2. Only "1,896 reviews" shown

Popup is shown:

After I close the popup:

3. "1,896 reviews" shown along with random percentage

Popup is shown, however with "1,896 reviews" and a random percentage already shown in the background (sometimes 60%, 58.6% or 49.3%):



After I close the popup:

As @user1823 has mentioned already, this really seems to happen due to a race condition. My laptop is running on a 14 year old CPU which may make it more likely for this race condition to occur.

Environment

• Anki version: 24.06.3
• OS: Debian GNU/Linux

[brishtibheja]

Not seeing the percentages is weirder. You are supposed to see the percentage rise to 100 per cent as the optimisation completes.

[dae]

I suspect that the progress update notifications are arriving asynchronously, and one or more is arriving after the operation has fully completed. Perhaps we could fix it by:

• in computeWeights(), using the returned reviews number, which is currently ignored in favor of the reviews listed in the progress messages
• hiding progress once the total reviews number has been returned