Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new revlog entry for "Reschedule cards on change" #3357

Closed
user1823 opened this issue Aug 14, 2024 · 5 comments · Fixed by #3508
Closed

Create a new revlog entry for "Reschedule cards on change" #3357

user1823 opened this issue Aug 14, 2024 · 5 comments · Fixed by #3508

Comments

@user1823
Copy link
Contributor

Currently, the revlog entry for "Reschedule cards on change" is the same as that for "Set Due Date". This is the cause of several issues, including

There must be other issues too that I am not remembering.

The solution is to use a separate revlog entry to distinguish "Reschedule cards on change" and "Set Due Date".

The first step is to decide the column in the revlog table whose value can be changed while minimizing add-on breakage (they may be making assumptions about the possible values).
Possible options: type, ease, factor

IMO, type is the only column where a change would appear to be "logically" correct. However, I am not sure if using type = 5 for "Reschedule cards on change" would lead to significant add-on breakage.

@brishtibheja
Copy link
Contributor

I assume it has to be an +ve integer number?

@dae
Copy link
Member

dae commented Aug 15, 2024

Type=5 is the most logical. I'm not too concerned about add-ons as we've added '4' in the past too, but it will require going through the Anki codebase to make sure we handle that case in all the graphs/stats.

@brishtibheja
Copy link
Contributor

I assume the search prop:resched will still work for us users? That's sometimes useful.

@dae
Copy link
Member

dae commented Sep 20, 2024

If it is useful to distinguish them in a search, we might want to add a new search term?

@user1823
Copy link
Contributor Author

user1823 commented Oct 8, 2024

I hope that 24.10 would have a new revlog entry for "Reschedule cards on change". The faster we fix this issue, the lesser would be the number of ambiguous revlogs in users' collections.

"A stitch in time saves nine."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants