Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test_expand #3

Closed
annh3 opened this issue Aug 1, 2024 · 2 comments
Closed

fix test_expand #3

annh3 opened this issue Aug 1, 2024 · 2 comments

Comments

@annh3
Copy link
Owner

annh3 commented Aug 1, 2024 •
edited
Loading

  1. Code is getting unreadable. Create a Beam_Item class to keep track of candidate beams, in particular with a field beam_tokens to keep track of the tokens as a single Tensor (1, seq_len_so_far)

AND

  1. After each call to logits_to_token_strings, make sure beam_tokens is updated with the newly generated token
@annh3 annh3 changed the title fix test_expand, test_main_algorithm, test_select fix test_expand Aug 9, 2024
@annh3
Copy link
Owner Author

annh3 commented Aug 16, 2024

Fixed by: e981b8b

@annh3 annh3 closed this as completed Aug 16, 2024
@annh3
Copy link
Owner Author

annh3 commented Aug 16, 2024

In retrospect, (1) was unecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annh3