Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: check node sync status #94

Closed
tzemanovic opened this issue Apr 6, 2022 · 4 comments · Fixed by #1258
Closed

client: check node sync status #94

tzemanovic opened this issue Apr 6, 2022 · 4 comments · Fixed by #1258

Comments

@tzemanovic
Copy link
Member

We can leverage tendermint status method (https://docs.tendermint.com/master/rpc/#/Info/status) to print some stats about a node including whether it's synced or syncing to add e.g. anomac node-status command with optional --ledger-address arg, defaulting to the same value as for e.g. transaction and query CLI commands.

@cwgoes
Copy link
Contributor

cwgoes commented Jan 12, 2023

@bengtlofgren can you take this on (should be an easy one)?

@tzemanovic
Copy link
Member Author

with the fix from #1182, where we stop committing genesis state in init-chain, we should also ensure that there is at least one block committed before proceeding with client commands - this can be a part of the same check

@tzemanovic
Copy link
Member Author

tzemanovic commented Mar 6, 2023

with the fix from #1182, where we stop committing genesis state in init-chain, we should also ensure that there is at least one block committed before proceeding with client commands - this can be a part of the same check

Alternatively, we could re-do the init-chain to still commit to DB, which would mean that there's no issues with queries before the first block, but we'll need to ensure that it's not being committed twice. We might need to change the DB interface a bit for that or add some flag when it’s being committed that we could check during init-chain (as there is no block being created by it). Not sure if that's worth it as it's pretty minuscule improvement

@tzemanovic
Copy link
Member Author

with the fix from #1182, where we stop committing genesis state in init-chain, we should also ensure that there is at least one block committed before proceeding with client commands - this can be a part of the same check

This one is causing some pain in e2e tests so I'll set this to higher prio. The current workaround is to wait for a first block before any queries and txs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

3 participants