-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clap to the latest v4 version #1580
Conversation
@tzemanovic Clap has removed colored help output in v4. |
That's a shame though overall I think it's being improved so good to stay up-to-date. Looks like a lot of the e2e tests are affected for some reason |
5eecaa1
to
31a4953
Compare
@tzemanovic > Looks like a lot of the e2e tests are affected for some reason |
thx! The last failed e2e test should be fixed in new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add a changelog
a49bf7d
to
883597c
Compare
@tzemanovic Done |
eb07824
to
47b127b
Compare
I'll rebase onto latest |
47b127b
to
61fb64e
Compare
* aleks/clap-up-v4: Add changelog Enable color output Update clap to latest v4 Update clap to latest v3
I'm having some trouble with this in #1603 draft. There's a failing e2e test in CI, but when I try to run it locally it fails for me earlier than that at the command The application panicked (crashed).
Message: Mismatch between definition and access of `chain-id`. Unknown argument or group id. Make sure you are using the argument id and not the short or long flags
Location: apps/src/lib/cli/utils.rs:314
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
⋮ 8 frames hidden ⋮
9: clap_builder::parser::error::MatchesError::unwrap::h4377723c4aa77431
at /home/tz/.cargo/registry/src/github.com-1ecc6299db9ec823/clap_builder-4.3.5/src/parser/error.rs:32
10: clap_builder::parser::matches::arg_matches::ArgMatches::get_one::hf4b5105e4827a7bd
at /home/tz/.cargo/registry/src/github.com-1ecc6299db9ec823/clap_builder-4.3.5/src/parser/matches/arg_matches.rs:115
11: namada_apps::cli::utils::parse_opt::h33b8ec3b64ec1e79
at /home/tz/dev/namada-2/apps/src/lib/cli/utils.rs:314
12: namada_apps::cli::utils::ArgOpt<T>::parse::h3eff49e0d32aa3d1
at /home/tz/dev/namada-2/apps/src/lib/cli/utils.rs:197
13: namada_apps::cli::args::<impl namada_apps::cli::utils::Args for namada::ledger::args::Tx<namada_apps::cli::args::CliTypes>>::parse::h204b9eb3b4dfb1cc
at /home/tz/dev/namada-2/apps/src/lib/cli.rs:3399
14: namada_apps::cli::args::<impl namada_apps::cli::utils::Args for namada::ledger::args::TxInitValidator<namada_apps::cli::args::CliTypes>>::parse::h5b99dfc697be870c
at /home/tz/dev/namada-2/apps/src/lib/cli.rs:2341
15: <namada_apps::cli::cmds::TxInitValidator as namada_apps::cli::utils::SubCmd>::parse::{{closure}}::h9a2c31a6dc417cb0
at /home/tz/dev/namada-2/apps/src/lib/cli.rs:1205 |
Ah so it's not just draft, I'm also have the same problem on this branch |
The problem was a missing arg definition for chain-id arg in Tx. It was introduced in merge of #925 but previous clap version wasn't able to detect it. Clap only does the detection in debug build (when |
Great that you found it! |
* aleks/clap-up-v4: cli: add a missing chain ID arg
Closes #64