update clap to stable release

[tzemanovic]

we're using the beta version of clap 0.3, which now has stable release: https://github.com/clap-rs/clap/releases

┆Issue is synchronized with this Asana task by Unito

[tzemanovic]

this might be a "good first issue" depending how many breaking changes there are

[cwgoes]

@juped is this still applicable?

[karbyshev]

I have found that it is possible to update clap to v3.0.13 with minimal changes. See #1537

When building with versions >= 3.0.14, the following issue emerges: entries for sub-commands in the help message appear twice. For example, ./target/debug/namadaw --help prints

Namada v0.17.0-1-gc04d113-dirty
Namada wallet command line interface.

USAGE:
    namadaw [OPTIONS] <SUBCOMMAND>

OPTIONS:
        --base-dir <base-dir>    The base directory is where the nodes, client and wallet
                                 configuration and state is stored. This value can also be set via
                                 `NAMADA_BASE_DIR` environment variable, but the argument takes
                                 precedence, if specified. Defaults to `$XDG_DATA_HOME/namada`
                                 (`$HOME/.local/share/namada` where `XDG_DATA_HOME` is unset) on
                                 Unix,`$HOME/Library/Application Support/Namada` on Mac,and
                                 `%AppData%\Namada` on Windows.
        --chain-id <chain-id>    The chain ID.
    -h, --help                   Print help information
        --mode <mode>            The mode in which to run Namada. Options are
                                 	 * Validator (default)
                                 	 * Full
                                 	 * Seed
    -V, --version                Print version information
        --wasm-dir <wasm-dir>    Directory with built WASM validity predicates, transactions. This
                                 value can also be set via `NAMADA_WASM_DIR` environment variable,
                                 but the argument takes precedence, if specified.

SUBCOMMANDS:
    address    Address management, including methods to generate and look-up addresses.
    address    Address management, including methods to generate and look-up addresses.
    help       Print this message or the help of the given subcommand(s)
    key        Keypair management, including methods to generate and look-up keys.
    key        Keypair management, including methods to generate and look-up keys.
    masp       Multi-asset shielded pool address and keypair management including methods to
               generate and look-up addresses and keys.
    masp       Multi-asset shielded pool address and keypair management including methods to
               generate and look-up addresses and keys.

I could not figure out what changes in clap-rs/clap@v3.0.13...v3.0.14 are causing the problem.

[tzemanovic]

Ah, looks like it's from a change in fn write_subcommands inside src/output/help.rs - it was previously using BTreeMap which was de-duplicating subcommands. It looks like in v4 they added some assertions to catch these, but there are bunch of breaking changes.

I found where we're inserting dups in our code in apps/src/lib/cli.rs:

• in fn namada_node/client/wallet_app we're calling cmds::NamadaNode/Client/Wallet::add_sub
• in fn namada_node/wallet_cli we're calling cmds::NamadaNode/Wallet::parse_or_print_help which again calls Self::add_sub(app) on the first line - I think we should remove this call
• in fn namada_client_cli we're calling cmds::NamadaClient::add_sub(app) - let's also remove this one

[karbyshev]

@tzemanovic Thanks! The suggested changes have helped. It compiles now with the latest v3 version.