Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add delete prefix #1632

Merged
merged 7 commits into from
Jul 6, 2023
Merged

storage: add delete prefix #1632

merged 7 commits into from
Jul 6, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jun 30, 2023

based on v0.18.0

Closes #1225

This depends on #1633 which needs to be fixed first as it's failing the test that's being added here.

@brentstone brentstone mentioned this pull request Jul 2, 2023
6 tasks
tzemanovic added a commit that referenced this pull request Jul 3, 2023
@tzemanovic tzemanovic marked this pull request as ready for review July 3, 2023 10:09
@tzemanovic tzemanovic requested review from yito88 and brentstone and removed request for yito88 July 3, 2023 15:07
Copy link
Contributor

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx :)

brentstone added a commit that referenced this pull request Jul 4, 2023
* tomas/delete-prefix:
  changelog: add #1632
  storage_api/lazy_map: remove entries by prefixed key
  test/core/wl_storage: extend prefix iter test to include delete prefix
  core/storage_api: add `StorageWrite::delete_prefix`
  changelog: add #1642
  test/storage/rocksdb: check that prefix_iter matches only full segments
  ledger/db: ensure that prefix iter only matches full key segments
@brentstone brentstone mentioned this pull request Jul 4, 2023
@murisi murisi mentioned this pull request Jul 4, 2023
murisi pushed a commit that referenced this pull request Jul 4, 2023
brentstone added a commit that referenced this pull request Jul 5, 2023
* tomas/delete-prefix:
  changelog: add #1632
  storage_api/lazy_map: remove entries by prefixed key
  test/core/wl_storage: extend prefix iter test to include delete prefix
  core/storage_api: add `StorageWrite::delete_prefix`
  changelog: add #1642
  test/storage/rocksdb: check that prefix_iter matches only full segments
  ledger/db: ensure that prefix iter only matches full key segments
Fraccaman added a commit that referenced this pull request Jul 6, 2023
* origin/tomas/delete-prefix:
  changelog: add #1632
  storage_api/lazy_map: remove entries by prefixed key
  test/core/wl_storage: extend prefix iter test to include delete prefix
  core/storage_api: add `StorageWrite::delete_prefix`
  changelog: add #1642
  test/storage/rocksdb: check that prefix_iter matches only full segments
  ledger/db: ensure that prefix iter only matches full key segments
@brentstone brentstone merged commit 644a6a6 into main Jul 6, 2023
9 of 12 checks passed
@brentstone brentstone deleted the tomas/delete-prefix branch July 6, 2023 11:29
brentstone added a commit that referenced this pull request Jul 6, 2023
Namada 0.18.1 is a patch release that addresses transaction format changes and minor ledger storage improvements.

* tag 'v0.18.1':
  Namada 0.18.1
  added chagelog
  Added changelog entry.
  clippy, fmt
  Simplified the reveal PK transaction construction flow. Factored chain_id reading from submit functions.
  Allow Tx builders to take verification keys.
  Increased usage of PublicKeys relative to SecretKeys in tx construction.
  Only reveal a public key when the signer is an implicit address.
  Now only use TxBroadcastData::Wrapper for non dry runs.
  Now update proof of work solution in transaction header.
  Separating out the reveal PK transaction construction.
  Separate transaction building from signing from submission.
  Removed unnecessary header updates for dry runs.
  clippy
  fmt and clippy
  Update .github/PULL_REQUEST_TEMPLATE/new_topic.md
  hopefully fixes init_network
  Added a changelog entry.
  Stop encrypting transactions in tests.
  Disable encrypting transactions when sending.
  git: added topic PR template
  fix: increase the genesis parameter
  changelog: add #1632
  storage_api/lazy_map: remove entries by prefixed key
  test/core/wl_storage: extend prefix iter test to include delete prefix
  core/storage_api: add `StorageWrite::delete_prefix`
  changelog: add #1642
  test/storage/rocksdb: check that prefix_iter matches only full segments
  ledger/db: ensure that prefix iter only matches full key segments
  fix `unclog release` command
  Added changelog entry.
  Fixed processing of code inside init-proposal transactions.
  changelog: add #1642
  test/storage/rocksdb: check that prefix_iter matches only full segments
  Update build_network.sh
  Added changelog entry.
  [fix]: CMT_LOG_LEVEL is now correct, not TM_LOG_LEVEL
  ledger/db: ensure that prefix iter only matches full key segments
  fix annoying error on line 69
  [fix]: Fix failing test-wasm by adding code section and also signing over that.
  docs: update rust-analyzer clippy override
  Expanded validate_header to check for signature over all sections, and renamed it to validate_tx.
  Make the signature section unmalleable.
  VPs now check that code and data are signed together.
  Fixed clippy and formatting issues.
  Fixed the tests involving transaction signing.
  Now sign over all sections in transactions.
  Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view.
  Now moving proposal code into extra section.
  Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: consider adding delete_prefix
3 participants