storage prefix iter: skip keys that don't match the full prefix segments #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
added a commit
that referenced
this pull request
Jul 3, 2023
tzemanovic
force-pushed
the
tomas/iter-prefix-full-match
branch
from
2e1db0d
to
f5ed324
Compare
brentstone
pushed a commit
that referenced
this pull request
Jul 4, 2023
brentstone
added a commit
that referenced
this pull request
Jul 4, 2023
* tomas/delete-prefix: changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
brentstone
added a commit
that referenced
this pull request
Jul 5, 2023
* tomas/iter-prefix-full-match: changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
brentstone
added a commit
that referenced
this pull request
Jul 5, 2023
* tomas/delete-prefix: changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
Fraccaman
added a commit
that referenced
this pull request
Jul 6, 2023
* origin/tomas/iter-prefix-full-match: changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
Fraccaman
added a commit
that referenced
this pull request
Jul 6, 2023
* origin/tomas/delete-prefix: changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
Closed
Fraccaman
added a commit
that referenced
this pull request
Jul 6, 2023
* origin/tomas/delete-prefix: changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments
brentstone
added a commit
that referenced
this pull request
Jul 6, 2023
Namada 0.18.1 is a patch release that addresses transaction format changes and minor ledger storage improvements. * tag 'v0.18.1': Namada 0.18.1 added chagelog Added changelog entry. clippy, fmt Simplified the reveal PK transaction construction flow. Factored chain_id reading from submit functions. Allow Tx builders to take verification keys. Increased usage of PublicKeys relative to SecretKeys in tx construction. Only reveal a public key when the signer is an implicit address. Now only use TxBroadcastData::Wrapper for non dry runs. Now update proof of work solution in transaction header. Separating out the reveal PK transaction construction. Separate transaction building from signing from submission. Removed unnecessary header updates for dry runs. clippy fmt and clippy Update .github/PULL_REQUEST_TEMPLATE/new_topic.md hopefully fixes init_network Added a changelog entry. Stop encrypting transactions in tests. Disable encrypting transactions when sending. git: added topic PR template fix: increase the genesis parameter changelog: add #1632 storage_api/lazy_map: remove entries by prefixed key test/core/wl_storage: extend prefix iter test to include delete prefix core/storage_api: add `StorageWrite::delete_prefix` changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments ledger/db: ensure that prefix iter only matches full key segments fix `unclog release` command Added changelog entry. Fixed processing of code inside init-proposal transactions. changelog: add #1642 test/storage/rocksdb: check that prefix_iter matches only full segments Update build_network.sh Added changelog entry. [fix]: CMT_LOG_LEVEL is now correct, not TM_LOG_LEVEL ledger/db: ensure that prefix iter only matches full key segments fix annoying error on line 69 [fix]: Fix failing test-wasm by adding code section and also signing over that. docs: update rust-analyzer clippy override Expanded validate_header to check for signature over all sections, and renamed it to validate_tx. Make the signature section unmalleable. VPs now check that code and data are signed together. Fixed clippy and formatting issues. Fixed the tests involving transaction signing. Now sign over all sections in transactions. Added CLI subcommand for validator change commission. Cleared up the MASP source and target in test vector expert view. Now moving proposal code into extra section. Increased the number of init-proposal and vote-proposal test vectors. Moved init-proposal content into extra data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1615
fixes #1633