Control the flow of wrapped NAM over the Ethereum bridge #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
added
has-a-pr
batconjurer
requested changes
Aug 4, 2023
tzemanovic
reviewed
Aug 4, 2023
tzemanovic
reviewed
Aug 4, 2023
tzemanovic
previously approved these changes
Aug 4, 2023
Fraccaman
previously approved these changes
Aug 7, 2023
2 tasks
batconjurer
reviewed
Aug 17, 2023
ethereum_bridge/src/protocol/transactions/ethereum_events/events.rs
Outdated
Show resolved
Hide resolved
batconjurer
reviewed
Aug 17, 2023
batconjurer
previously approved these changes
Aug 17, 2023
sug0
force-pushed
the
tiago/token-whitelist
branch
from
06d3a3d
to
20044d0
Compare
Closed
sug0
dismissed stale reviews from batconjurer, Fraccaman, and tzemanovic
The base branch was changed.
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/cap-wnam: Add changelog for #1781 Add invalidate_wnam_over_cap_tx() unit test Fix wNAM edge cases in Bridge pool VP unit tests New Bridge pool VP unit tests for wrapped NAM Add `asset` field to Balance Refactor Bridge pool tests to allow modifying pending transfer Fix test_act_on_changes_storage_for_transfers_to_eth() unit test Test that wrapped NAM is never minted Fix test_redeem_native_token() unit test Fix test_wrapped_nam_not_burned() unit test Add test_wnam_doesnt_mint_nuts() unit test Refactor get_erc20_flow_control to use EthBridgeQueries Replace ERC20 supply RPC query with atomic read of all flow control data Flow control of NAM transferred to Ethereum Allow null pre-balances during Bridge pool escrow checks Update wNAM supplies when acting on Ethereum events Harden Bridge pool VP against wNAM NUT transfers Vet Ethereum bridge config of the native token Refactor redeem_native_token to use update::amount Use EthAssetMint helper methods Add helper methods to EthAssetMint
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/cap-wnam: Add changelog for #1781 Add invalidate_wnam_over_cap_tx() unit test Fix wNAM edge cases in Bridge pool VP unit tests New Bridge pool VP unit tests for wrapped NAM Add `asset` field to Balance Refactor Bridge pool tests to allow modifying pending transfer Fix test_act_on_changes_storage_for_transfers_to_eth() unit test Test that wrapped NAM is never minted Fix test_redeem_native_token() unit test Fix test_wrapped_nam_not_burned() unit test Add test_wnam_doesnt_mint_nuts() unit test Refactor get_erc20_flow_control to use EthBridgeQueries Replace ERC20 supply RPC query with atomic read of all flow control data Flow control of NAM transferred to Ethereum Allow null pre-balances during Bridge pool escrow checks Update wNAM supplies when acting on Ethereum events Harden Bridge pool VP against wNAM NUT transfers Vet Ethereum bridge config of the native token Refactor redeem_native_token to use update::amount Use EthAssetMint helper methods Add helper methods to EthAssetMint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1722
The PR is configured to merge into the base (tiago/token-whitelist) to make reviewing easier. It should be changed back to
main, once the base is upstreamed.Indicate on which release or other PRs this topic is based on
Based on #1755
Checklist before merging to
draft