Remove non-essential fields from ERC20 transfer structs #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/update-ethbridge-rs
branch
from
97319a5
to
1ac1406
Compare
batconjurer
reviewed
Aug 8, 2023
batconjurer
reviewed
Aug 8, 2023
batconjurer
reviewed
Aug 8, 2023
batconjurer
previously approved these changes
Aug 8, 2023
2 tasks
sug0
force-pushed
the
tiago/update-ethbridge-rs
branch
from
1ac1406
to
80854c5
Compare
tzemanovic
previously approved these changes
Aug 9, 2023
sug0
force-pushed
the
tiago/update-ethbridge-rs
branch
from
80854c5
to
5678ee7
Compare
Closed
sug0
dismissed stale reviews from tzemanovic and batconjurer
The base branch was changed.
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/update-ethbridge-rs: Changelog for #1789 Test pending transfers and events have the same ABI encoding Fix compilation errors to support new `ethbridge-rs` Update ethbridge-rs to v0.22.0
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/update-ethbridge-rs: Changelog for #1789 Test pending transfers and events have the same ABI encoding Fix compilation errors to support new `ethbridge-rs` Update ethbridge-rs to v0.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
To implement #1704, a new field would have to be added to the
Erc20Transferstruct inBridge.sol, such that we could preserve the token type used to pay gas fees. Namada stores pending Bridge pool transfers as part of the protocol, so there is no reason for the Ethereum smart contracts to have any knowledge of Namada-specific metadata. This PR addresses this, by removing all non-essential fields. A mapping of confirmed Ethereum events to pending transfers kept in Namada's storage can still be obtained by hashing all Namada metadata, and storing it inErc20Transferstructs.The PR is configured to merge into the base (tiago/cap-wnam) to make reviewing easier. It should be changed back to
main, once the base is upstreamed.Indicate on which release or other PRs this topic is based on
Based on #1781
Checklist before merging to
draft