Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/lazy_map+set: avoid calling delete when given key is not present #1984

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 13, 2023

Describe your changes

closes #1981

Indicate on which release or other PRs this topic is based on

0.23.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic marked this pull request as ready for review October 13, 2023 15:25
Copy link
Contributor

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I checked the behavior locally in a dummy e2e test env and it works. Thx!

@brentstone brentstone mentioned this pull request Oct 16, 2023
brentstone added a commit that referenced this pull request Oct 16, 2023
* tomas/rm-redundant-writes:
  changelog: add #1984
  core/lazy_map+set: avoid calling delete when given key is not present
brentstone added a commit that referenced this pull request Oct 16, 2023
* tomas/rm-redundant-writes:
  changelog: add #1984
  core/lazy_map+set: avoid calling delete when given key is not present
@brentstone brentstone mentioned this pull request Oct 17, 2023
2 tasks
Fraccaman added a commit that referenced this pull request Oct 23, 2023
* origin/tomas/rm-redundant-writes:
  changelog: add #1984
  core/lazy_map+set: avoid calling delete when given key is not present
tzemanovic added a commit that referenced this pull request Oct 24, 2023
* tomas/rm-redundant-writes:
  changelog: add #1984
  core/lazy_map+set: avoid calling delete when given key is not present
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
@tzemanovic tzemanovic merged commit 672e153 into main Oct 24, 2023
13 of 14 checks passed
@tzemanovic tzemanovic deleted the tomas/rm-redundant-writes branch October 24, 2023 11:26
brentstone pushed a commit that referenced this pull request Nov 11, 2023
* tomas/rm-redundant-writes:
  changelog: add #1984
  core/lazy_map+set: avoid calling delete when given key is not present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoS bond tx touchs more validator delta keys than expected
3 participants