-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoS rewards #1992
Merged
Merged
PoS rewards #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/pos-rewards
branch
4 times, most recently
from
October 20, 2023 19:58
77bb377
to
630c372
Compare
tzemanovic
force-pushed
the
brent/pos-rewards
branch
from
October 26, 2023 14:49
bca382b
to
dce531e
Compare
brentstone
force-pushed
the
brent/pos-rewards
branch
from
October 30, 2023 15:16
dce531e
to
a6121e0
Compare
brentstone
force-pushed
the
brent/pos-rewards
branch
from
November 7, 2023 11:15
98ce062
to
738ee3d
Compare
Closed
Closed
brentstone
force-pushed
the
brent/pos-rewards
branch
from
November 7, 2023 15:49
4dd7d8c
to
7cb1d08
Compare
Closed
brentstone
force-pushed
the
brent/pos-rewards
branch
from
November 7, 2023 20:44
7cb1d08
to
30ae254
Compare
brentstone
added a commit
that referenced
this pull request
Nov 8, 2023
brentstone
force-pushed
the
brent/pos-rewards
branch
4 times, most recently
from
November 8, 2023 19:53
a5f1432
to
de3e50b
Compare
brentstone
added a commit
that referenced
this pull request
Nov 9, 2023
brentstone
force-pushed
the
brent/pos-rewards
branch
from
November 9, 2023 18:23
de3e50b
to
65452b0
Compare
tzemanovic
reviewed
Nov 10, 2023
genesis/e2e-tests-single-node.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look like this is accidentally revived
tzemanovic
previously approved these changes
Nov 10, 2023
brentstone
force-pushed
the
brent/pos-rewards
branch
from
November 10, 2023 13:59
df1850e
to
72d16d8
Compare
tzemanovic
approved these changes
Nov 10, 2023
brentstone
added a commit
that referenced
this pull request
Nov 10, 2023
* brent/pos-rewards: add test for commissions and fix `bond_amounts_for_rewards` fix tests update `bond_amounts_for_rewards` and `bond_amount` misc lib code improvements fix rewards tallying: move from within withdraw -> unbond add and update tests changelog: add #1992 updates to enable tx from CLI update to 0.25.0 base change default `kD` and `kP` params playground for testing how inflation changes WIP more tests benches: add a const for "tx_claim_rewards.wasm" test/PoS: add rewards related tests add a tx to claim PoS rewards PoS: apply inflation after processing slashes PoS: refactors to use helper functions PoS: allow to claim rewards PoS: update rewards products to handle commission correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A claim-based rewards system for proof-of-stake. Inflationary rewards do not automatically contribute to voting power, but rather must be claimed/withdrawn.
Closes #1130, closes #1770, closes #2058.
Indicate on which release or other PRs this topic is based on
v0.25.0
Checklist before merging to
draft