ledger: improve genesis flow #685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
fb156d5
to
9ea6ce8
Compare
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
9ea6ce8
to
ad489a1
Compare
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
ad489a1
to
cf81f4e
Compare
Closed
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
cf81f4e
to
5763c1c
Compare
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
3 times, most recently
from
97c2d43
to
ba4f4a6
Compare
This was referenced Jan 12, 2023
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
ba4f4a6
to
142442c
Compare
This was referenced Feb 1, 2023
Closed
Added a test that the genesis chain `fn finalize` is deterministic.
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
142442c
to
f6450d7
Compare
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
f6450d7
to
05f690f
Compare
tzemanovic
force-pushed
the
tomas+fraccaman/new-genesis
branch
from
05f690f
to
40414c2
Compare
|
@Fraccaman I'm closing this. I think when the feature is ready to be merged, you can cherry pick commits from this branch. |
Closed
adrianbrink
reviewed
May 31, 2023
| vp = "vp_validator" | ||
| commission_rate = "0.05" | ||
| max_commission_rate_change = "0.01" | ||
| net_address = "127.0.0.1:27656" |
There was a problem hiding this comment.
I'm not sure why we need to include this parameter in the genesis process. This is strictly a configuration parameter that can be changed freely locally.
There was a problem hiding this comment.
For local and automated networks setup it is convenient to have it here to be able to establish connections without bootstrap peers. We can make it optional for when we don't need it
Closed
2 tasks
tzemanovic
reviewed
Aug 4, 2023
| predicates files." | ||
| ); | ||
| is_valid = false; | ||
| } |
There was a problem hiding this comment.
we should add a call here to validate PoS params with e.g.:
let pos_errs = parameters.pos_params.validate();
if !pos_errs.is_empty() {
eprintln!("PoS params are invalid: {pos_errs:?}");
is_valid = false;
}
Closed
|
this is being worked on in #1840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #870 and #849
fix #711, fix #6, fix #45, fix #95, fix #115, fix #116, #470