Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure Token Storage #9

Open
detronetdip opened this issue Sep 24, 2022 · 4 comments · May be fixed by #10
Open

Secure Token Storage #9

detronetdip opened this issue Sep 24, 2022 · 4 comments · May be fixed by #10
Assignees
@detronetdip
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@detronetdip
Copy link
Contributor

Current code base is using local storage for storing the DID token, however it is not a good practice as it can be accessed by browser's JavaScript. Instead of that we can use httpOnly cookies to store them.
@anomic30
Copy link
Owner

You are right. Assigning this to you.

@anomic30 anomic30 added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Sep 24, 2022
@Onesco
Copy link
Contributor

Onesco commented Sep 24, 2022

Hello @anomic30 i would love to work on this is the the task is still available. Thanks

@detronetdip
Copy link
Contributor Author

Hey @Onesco actually I am already working on this.

@Onesco
Copy link
Contributor

Onesco commented Sep 25, 2022

@detronetdip thanks for the feedback.

@detronetdip detronetdip linked a pull request Oct 7, 2022 that will close this issue
Draft
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@detronetdip detronetdip

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Token security detronetdip/Storz
3 participants
@Onesco @anomic30 @detronetdip