Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This stinks.. multiple issues #31

Closed
jlautner opened this issue Apr 13, 2017 · 2 comments
Closed

This stinks.. multiple issues #31

jlautner opened this issue Apr 13, 2017 · 2 comments

Comments

@jlautner
Copy link

My god, these plugins should have reviews on them. I spent 2 hours trying to get this thing working... it looks great, screens shots look great, but if I have to get into putty and install yagmail and keyring and other stuff after digging around to find out why none of it can be found, figure out what virtual profiles are... all this to get a simple email notification? Why use Yagmail, why don't you just use smtplib? Is all this so that passwords are stored securely? Who cares about that, if they have access to your script files from the internet you have bigger problems, having the password accessible by the script wouldn't matter.
Why not have a test button, so you can test the setup?
Why not have a port number option, for non-standard SMTP ports
Why not have TLS option and other standard SMTP settings
I need to just make another completely different plugin that works and installs in one step... this one is pretty much useless. I finally got it all setup, and I don't even know if it works; testing from the yagmail shows it is still not working. WOW.

@anoved
Copy link
Owner

anoved commented Apr 14, 2017

Thank you for your feedback. The answer to most of your questions is that I am a novice hobbyist Python programmer who has not been able to keep up with OctoPrint API changes. I wrote this plugin as a proof-of-concept for my own use and have shared it in hopes it would provide a starting point for others. If you read my responses to other reported issues, you will note that I have openly acknowledged this ability deficit and have repeatedly invited others with more expertise to contribute fixes to the exact problems you have noted. Please do write another completely different plugin that works and installs in one step; I will use it and direct visitors to this page to do so as well.

Lastly, please re-read your report and recognize that your written conduct is unkind. Your technical criticism is valid but your insulting tone is not.

@jlautner
Copy link
Author

jlautner commented Apr 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants