Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip formatting machinery in text nodes without format args #274

Open
anp opened this issue May 6, 2021 · 1 comment
Open

Skip formatting machinery in text nodes without format args #274

anp opened this issue May 6, 2021 · 1 comment
Labels
dom Related to moxie-dom and associated crates

Comments

@anp
Copy link
Owner

anp commented May 6, 2021

https://github.com/anp/moxie/blob/main/dom/src/interfaces/node.rs#L65

https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str is stable as of 1.53.

@anp anp added the dom Related to moxie-dom and associated crates label May 6, 2021
@zetanumbers
Copy link
Contributor

So um, this method is useful if format_args! has no args. Btw i think we could use .to_string() or thread local buffer for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dom Related to moxie-dom and associated crates
Projects
None yet
Development

No branches or pull requests

2 participants