Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang compiler support #95

Closed
topilski opened this issue May 24, 2017 · 4 comments
Closed

Clang compiler support #95

topilski opened this issue May 24, 2017 · 4 comments

Comments

@topilski
Copy link
Contributor

topilski commented May 24, 2017

Hi, please add clang compiler support, bcuz on MacOSX in mostly used clang as compiler. In code you can replace #if defined(COMPILER_GCC) to #if defined(COMPILER_GCC) || defined(COMPILER_CLANG) and this should work, also need to detect is compiler clang.

@anrieff
Copy link
Owner

anrieff commented May 24, 2017

Your fork already has it, right? In lieu of issue #96, I might just integrate that.

@orivej
Copy link
Contributor

orivej commented Jun 25, 2018

This might have been fixed by #112. (For me even libcpuid 0.4.0 builds on Linux and macOS with Clang, but I'm using stock Clang that defines __GNUC__, not Apple Clang.)

@anrieff
Copy link
Owner

anrieff commented Jun 27, 2018

Yes, I can confirm that libcpuid now compiles fine with clang 3.7.0 on Linux. Please report further issues.

@anrieff anrieff closed this as completed Jun 27, 2018
@anrieff
Copy link
Owner

anrieff commented Jun 27, 2018

And, of course, thanks for your contribution, @orivej :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants