Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close both connections on StreamSend failure #4

Open
anrossi opened this issue Oct 21, 2023 · 0 comments
Open

Close both connections on StreamSend failure #4

anrossi opened this issue Oct 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@anrossi
Copy link
Owner

anrossi commented Oct 21, 2023

If the StreamSend call fails, only one of the connections is closed (the peer's connection). This will leak the other connection. Find a place to store the stream's parent connection handle on the stream context (not just the peer's connection handle).
@anrossi anrossi added the bug Something isn't working label Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anrossi