Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary join() use #50

Closed
tomato42 opened this issue May 10, 2018 · 0 comments
Closed

unnecessary join() use #50

tomato42 opened this issue May 10, 2018 · 0 comments

Comments

@tomato42
Copy link

https://github.com/ansasaki/smap/blob/608f590b98a1ad2e12c078974eafeef8f4aa58fa/src/smap/symver.py#L584-L587

this is equivalent to

msg = ("More than one release seems the base"
       " version (contains the local wildcard" 
       " and does not have a predecessor" 
       " version):")

as Python doesn't require string concatenation operation inside parentheses
ansasaki added a commit that referenced this issue May 18, 2018
@ansasaki
Improved strings in warnings
5387e34 
Avoid the construction of the message if the purpose is just to be sent
as a warning.

Try to use format instead of join when possible.

Try to use generator instead of array comprehension.

Fixes #44, #45, #49, #50
@ansasaki ansasaki mentioned this issue May 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomato42