Update existing releases #64

ansasaki · 2018-05-18T16:29:50Z

Allow the user to update releases in development phase.
Prevent changes in released releases.

Various improvements in the code

When a comment starting with "release" (case insensitive) is found between the release name and the opening '{', the release is marked as released. This will be required to allow the user to update existing releases when in development phase and prevent released releases to be modified.

The test was incomplete and did not assert anything at all.

Removed redefined function. Fixed blank space issue.

Avoid the construction of the message if the purpose is just to be sent as a warning. Try to use format instead of join when possible. Try to use generator instead of array comprehension. Fixes #44, #45, #49, #50

coveralls · 2018-05-18T16:33:40Z

Pull Request Test Coverage Report for Build 106

98 of 98 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 97.733%

Totals
Change from base Build 102:	-0.07%
Covered Lines:	717
Relevant Lines:	723

💛 - Coveralls

codecov-io · 2018-05-18T16:33:40Z

Codecov Report

Merging #64 into master will decrease coverage by 0.18%.
The diff coverage is 98.97%.

@@            Coverage Diff            @@
##           master     #64      +/-   ##
=========================================
- Coverage   96.58%   96.4%   -0.19%     
=========================================
  Files           3       3              
  Lines         732     723       -9     
  Branches      180     187       +7     
=========================================
- Hits          707     697      -10     
  Misses          6       6              
- Partials       19      20       +1

Impacted Files	Coverage Δ
src/smap/symver.py	`96.34% <98.97%> (-0.19%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 142767d...4a31403. Read the comment docs.

- Added "--final" option to mark the changed release as final - Allow user to update an existing release - Do not allow user to modify a released release - Use dictionaries for visibility scopes - Merge visibility scopes with the same name when parsing Fixes #65, #62, #60

ansasaki added 4 commits May 18, 2018 15:25

Fixed broken test

7ee3c93

The test was incomplete and did not assert anything at all.

Fixed test

284b824

Removed redefined function. Fixed blank space issue.

Improved strings in warnings

5387e34

Avoid the construction of the message if the purpose is just to be sent as a warning. Try to use format instead of join when possible. Try to use generator instead of array comprehension. Fixes #44, #45, #49, #50

ansasaki changed the title ~~WIP: Update existing releases~~ Update existing releases May 24, 2018

ansasaki merged commit 9f0d1d0 into master May 24, 2018

ansasaki deleted the update_existing_releases branch May 24, 2018 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update existing releases #64

Update existing releases #64

ansasaki commented May 18, 2018 •

edited

Loading

coveralls commented May 18, 2018 •

edited

Loading

codecov-io commented May 18, 2018 •

edited

Loading

Update existing releases #64

Update existing releases #64

Conversation

ansasaki commented May 18, 2018 • edited Loading

coveralls commented May 18, 2018 • edited Loading

Pull Request Test Coverage Report for Build 106

💛 - Coveralls

codecov-io commented May 18, 2018 • edited Loading

Codecov Report

ansasaki commented May 18, 2018 •

edited

Loading

coveralls commented May 18, 2018 •

edited

Loading

codecov-io commented May 18, 2018 •

edited

Loading