Add support to AnsibleAWSModule.client to override the default parameters #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
clients/override
branch
from
823667e
to
dbba2b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
alinabuzachis
approved these changes
Dec 26, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
regate |
|
regate |
|
regate |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
Refactor S3 connection code SUMMARY Builds upon #1303 making the S3 code closer to the rest of our connection code. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object s3_object_info s3_bucket ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/community.aws#1635
SUMMARY
When refactoring the inventory plugins it was helpful to be able to override region, however looking at the S3 code, it's also helpful to be able to override other things too. Pull this in as a small change while I work on the rest of it.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/modules.py
ADDITIONAL INFORMATION