Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize: use _find_needle instead #433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mnaser
Copy link

@mnaser mnaser commented Mar 21, 2023

SUMMARY

It's not possible to use files from a sub role, this patch fixes this.

Fixes #381

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

synchornize

ADDITIONAL INFORMATION

See #381

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d98fe75b98a74d8e88bac6026a45b37e

ansible-changelog-fragment FAILURE in 15s
✔️ ansible-test-sanity-docker-devel SUCCESS in 6m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 9m 33s
✔️ ansible-test-sanity-docker-stable-2.10 SUCCESS in 9m 09s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 21s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 6m 54s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 11s
✔️ ansible-test-units-posix-python39 SUCCESS in 4m 42s
✔️ ansible-test-units-posix-python310 SUCCESS in 5m 47s
✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 6m 32s

@gtirloni
Copy link

@tima coud you review this PR?

@jillr
Copy link
Contributor

jillr commented May 9, 2024

@mnaser Apologies in the delay getting this reviewed. Would you be willing to add a changelog fragment to this PR?

mnaser and others added 2 commits July 17, 2024 15:57
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize cannot find directories from sub roles like copy does
4 participants