Remove collection runtime dependencies

[felixfontein]

SUMMARY

While including other collections for tests is fine, including them for runtime is dangerous. Changes in other collections can randomly break things in this collection.

I want to track dependencies to other collections in this issue, with the aim of being able to eventually remove them.

• google.cloud:
  • Runtime:
    • plugins/lookup/gcp_storage_file.py (uses function navigate_hash and class GcpSession)
• ansible.netcommon:
  • Runtime:
    • plugins/modules/net_tools/nios/nios_network.py (uses functions validate_ip_address, validate_ip_v6_address)
• ansible.posix:
  • Runtime:
    • plugins/modules/system/aix_filesystem.py (uses function ismount)
  • Testing only:
    • tests/unit/plugins/modules/system/interfaces_file/interfaces_file/test_interfaces_file.py
• cisco.intersight:
  • Runtime:
    • plugins/modules/remote_management/intersight/intersight_info.py (uses class IntersightModule and constant intersight_argument_spec next to docs fragment cisco.intersight.intersight)
• community.kubernetes:
  • Runtime:
    • plugins/connection/oc.py
    • plugins/inventory/kubevirt.py
    • plugins/module_utils/kubevirt.py
    • plugins/modules/cloud/kubevirt/kubevirt_vm.py
    • plugins/modules/cloud/kubevirt/kubevirt_rs.py
    • plugins/modules/cloud/kubevirt/kubevirt_pvc.py
    • plugins/modules/cloud/kubevirt/kubevirt_template.py
    • plugins/modules/cloud/kubevirt/kubevirt_cdi_upload.py
    • plugins/modules/cloud/kubevirt/kubevirt_preset.py
  • Testing only:
    • tests/unit/plugins/modules/cloud/kubevirt/test_kubevirt_rs.py
    • tests/unit/plugins/modules/cloud/kubevirt/kubevirt_fixtures.py

ISSUE TYPE

• Bug Report

COMPONENT NAME

collection

ANSIBLE VERSION

devel

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[felixfontein]

CC @gundalow @abadger @Andersson007

[felixfontein]

How I would proceed:

• google.cloud: just copy the required things over and drop the runtime dependency.
• ovirt.ovirt: vendor the requirements and mark them deprecated (as the modules themselves), and remove them once the modules are removed.

I guess the ansible.netcommon and ansible.posix dependencies shouldn't do random changes, so we can live with them.

I'm somewhat worried over cisco.intersight and community.kubernetes. If we could get rid of the modules/plugins, that would be great ;-) I guess that the dependent collections don't want to take them? That would be especially helpful for the cisco.intersight dependency, in particular because it has been authored by Cisco themselves. For the kubevirt stuff, moving it to a dedicated collection might help if community.kubernetes doesn't want to have it.

[felixfontein]

Looks like intersight_facts was moved to https://github.com/CiscoDevNet/ansible-intersight, while intersight_info was moved here. That makes no sense to me. Pinging @dsoper2 and @CiscoUcs as the module authors. I really think that intersight_info should also be moved to that collection.

[felixfontein]

I've added a commit to vendor the ovirt.ovirt parts to #353.

[dsoper2]

Looks like intersight_facts was moved to https://github.com/CiscoDevNet/ansible-intersight, while intersight_info was moved here. That makes no sense to me. Pinging @dsoper2 and @CiscoUcs as the module authors. I really think that intersight_info should also be moved to that collection.

Agreed - I had forgot the facts rename to info. I'll do the same rename in the collection and all cisco.intersight content (modules and utils) can be pulled from core.

[felixfontein]

#372 loosens the dependency on google.cloud: the gcp_storage_file plugin will error when being called, instead of terminating loading of lookup plugins for community.general when the import from ansible_collections.google.cloud fails.

[felixfontein]

@dsoper2 please CC me in the ansible/ansible PR which changes routing.

[felixfontein]

I've added plugins/connection/oc.py to the list of plugins depending on community.kubernetes (#577).

[felixfontein]

For the kubevirt modules, see ansible-collections/community.kubernetes#221. For oc see #866.

[felixfontein]

With the plan in ansible-collections/overview#117 (comment) all dependencies will vanish!

[felixfontein]

ansible.posix is no longer a runtime dependency! \o/

[felixfontein]

ansible.netcommon was removed in #1561, google.cloud in #1319. community.kubernetes will be removed in #1317, which will finally resolve this issue.