Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make playbook.arguments available in playbook list #28

Closed
dmsimard opened this issue Apr 24, 2019 · 10 comments
Closed

Make playbook.arguments available in playbook list #28

dmsimard opened this issue Apr 24, 2019 · 10 comments
Assignees
Labels
api Related to the API

Comments

@dmsimard
Copy link
Contributor

playbook.arguments is more or less a fixed size dict and we can afford to make it available in the playbook list call.

This will be useful for things like highlighting playbooks that ran with --check without needing to do a call for the playbook details. Example: ansible-community/ara-web#6

@dmsimard
Copy link
Contributor Author

dmsimard commented May 8, 2019

Merged as https://review.opendev.org/#/c/657847/

@dmsimard dmsimard closed this as completed May 8, 2019
@rntbrgtt
Copy link

rntbrgtt commented Jun 1, 2020

Hi,

I am sorry but I am using ARA 1.4 and running DryRuns here (--check) and I cant see it anywhere.

Am I missing something?

Regards,

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

Hi @rntbrgtt, this issue was about the API implementation so if you request /api/v1/playbooks the arguments are available.

These are not exposed in the reporting UI yet but is planned for the 1.5 release which will include UI refactoring work. You can see what the progress looks like so far on https://api.trunk.demo.recordsansible.org.

@rntbrgtt
Copy link

rntbrgtt commented Jun 1, 2020

Thanks for your quick reply.
New version looks awesome but I still can't see 'check = true' on the demo.
Will we be able to filter by remote_user as well?

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

"check" as well as "remote_user" are available in the CLI arguments:
Screenshot from 2020-06-01 10-05-28

It is not possible to filter by CLI arguments yet but it was requested in another issue: #119

In the meantime, I would like the --check playbooks to be highlighted differently in the playbook list and this can be done fairly easily without needing to implement the filtering.

@rntbrgtt
Copy link

rntbrgtt commented Jun 1, 2020

I personally think that remote_user is as important as check to be shown on playbooks list but anyway I really appreciate your time to reply my messages and your help with the community.

@dmsimard
Copy link
Contributor Author

dmsimard commented Jun 1, 2020

@rntbrgtt happy to help 🎉

ARA has a LOT of data to work with and it's definitely challenging from a UI/UX perspective to display everything in a way that makes sense.

For now my main objective is to at least expose the data and demonstrate the features working -- then, hopefully someone with expertise in frontend can come in and make it pretty and usable :)

@dmsimard
Copy link
Contributor Author

dmsimard commented Sep 18, 2020

Hey @rntbrgtt o/

I am experimenting with an implementation that might work for the needs of highlighting remote_user and --check and making them searchable and wanted to know what you thought about it:

Screenshot from 2020-09-18 10-54-05

The way it would work with this patch is that the callback could be configured to automatically label playbooks after certain CLI arguments (such as --check and --user).

Once labelled, it also enables search for those labels and this becomes sort of a workaround for lack of search for CLI arguments.

Let me know what you think :)

Edit: I guess I meant to reply in #148, oh well.

@rntbrgtt
Copy link

Hi @dmsimard ,

Thanks a lot for your effort on this project.

Showing remote_user and if it's a dry run or not and then being able to use this on to filter the search would be perfect for me. This looks awesome.

Looking forward to upgrading my ARA.

Regards,

@dmsimard
Copy link
Contributor Author

@rntbrgtt thanks for the quick feedback, much appreciated !

This is the last change to land before the release of v1.5 so unless anything goes wrong it should be out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the API
Projects
None yet
Development

No branches or pull requests

2 participants