-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make playbook.arguments available in playbook list #28
Comments
Merged as https://review.opendev.org/#/c/657847/ |
Hi, I am sorry but I am using ARA 1.4 and running DryRuns here (--check) and I cant see it anywhere. Am I missing something? Regards, |
Hi @rntbrgtt, this issue was about the API implementation so if you request These are not exposed in the reporting UI yet but is planned for the 1.5 release which will include UI refactoring work. You can see what the progress looks like so far on https://api.trunk.demo.recordsansible.org. |
Thanks for your quick reply. |
"check" as well as "remote_user" are available in the CLI arguments: It is not possible to filter by CLI arguments yet but it was requested in another issue: #119 In the meantime, I would like the --check playbooks to be highlighted differently in the playbook list and this can be done fairly easily without needing to implement the filtering. |
I personally think that remote_user is as important as check to be shown on playbooks list but anyway I really appreciate your time to reply my messages and your help with the community. |
@rntbrgtt happy to help 🎉 ARA has a LOT of data to work with and it's definitely challenging from a UI/UX perspective to display everything in a way that makes sense. For now my main objective is to at least expose the data and demonstrate the features working -- then, hopefully someone with expertise in frontend can come in and make it pretty and usable :) |
Hey @rntbrgtt o/ I am experimenting with an implementation that might work for the needs of highlighting The way it would work with this patch is that the callback could be configured to automatically label playbooks after certain CLI arguments (such as Once labelled, it also enables search for those labels and this becomes sort of a workaround for lack of search for CLI arguments. Let me know what you think :) Edit: I guess I meant to reply in #148, oh well. |
Hi @dmsimard , Thanks a lot for your effort on this project. Showing remote_user and if it's a dry run or not and then being able to use this on to filter the search would be perfect for me. This looks awesome. Looking forward to upgrading my ARA. Regards, |
@rntbrgtt thanks for the quick feedback, much appreciated ! This is the last change to land before the release of v1.5 so unless anything goes wrong it should be out next week. |
playbook.arguments is more or less a fixed size dict and we can afford to make it available in the playbook list call.
This will be useful for things like highlighting playbooks that ran with
--check
without needing to do a call for the playbook details. Example: ansible-community/ara-web#6The text was updated successfully, but these errors were encountered: