Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Tox failures due to the upgrade of importlib-metadata #31

Closed
abtreece opened this issue Nov 23, 2020 · 2 comments
Closed

Tox failures due to the upgrade of importlib-metadata #31

abtreece opened this issue Nov 23, 2020 · 2 comments

Comments

@abtreece
Copy link

Receiving test failures due to the recent upgrade of importlib-metadata to v3.0.0

virtualenv 20.2.0 has requirement importlib-metadata<3,>=0.12; python_version < "3.8", but you have importlib-metadata 3.0.0.

https://github.com/pypa/virtualenv/blob/ced984abfd4f1531f9075113e77af7ec01479d29/setup.cfg#L47

pypa/virtualenv#2019

@ssbarnea
Copy link
Member

I think you already know how to fix. For stuff like this is easier to just make PR to fix it. Until upstream fixes it add a local condition to help pip make a good decision, with comment linking the upstream bug.

@abtreece
Copy link
Author

The upstream issue seemed like an easy fix so I took a stab at that PR. I wanted to raise it as a known issue here so there was explanation for the test failures, etc. The upstream PR has been merged and released... ⚡

fixed by pypa/virtualenv#2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants