Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added instance_profile_name to ec2 driver #2370

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Added instance_profile_name to ec2 driver #2370

merged 2 commits into from
Oct 19, 2019

Conversation

retpolanne
Copy link
Contributor

  • Added instance_profile_name to EC2 driver (optional and backward compatible)

How to use it

  • Create role using EC2 driver: molecule init role -r test-ec2 -d ec2
  • Add instance_profile_name to platforms on molecule.yml

@retpolanne
Added instance_profile_name to ec2 driver
6b72bed 
Signed-off-by: Vinicyus Macedo <7549205+vinicyusmacedo@users.noreply.github.com>
decentral1se
decentral1se suggested changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It needs a test.

Please see other PRs for adding new options to the schema. It's a quick addition.

@retpolanne
Added unit tests for instance_profile_name
f478146 
Signed-off-by: Vinicyus Macedo <7549205+vinicyusmacedo@users.noreply.github.com>
@retpolanne
Copy link
Contributor Author

Hey @decentral1se, I added a test, but I couldn't really understand where I should keep EC2 functional tests.

@decentral1se
Copy link
Contributor

but I couldn't really understand where I should keep EC2 functional tests.

Don't exist or work yet :) Thanks!

decentral1se
decentral1se approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@decentral1se decentral1se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the failing build (unrelated):

https://travis-ci.com/ansible/molecule/builds/132061862

Will merge when we get a green CI.

🚀

@retpolanne
Copy link
Contributor Author

Thanks :)

@ssbarnea ssbarnea added this to the 3.0 milestone Oct 18, 2019
@ssbarnea ssbarnea merged commit 5c116e9 into ansible:master Oct 19, 2019
@lod lod mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decentral1se decentral1se decentral1se approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@retpolanne @decentral1se @ssbarnea